Github user jfarrell commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1096#discussion_r80729988
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -16,7 +16,9 @@
* specific language governing permissions and limitations
* under the License.
*/
-
+#if defined(_MSC_VER) && (_MSC_VER < 1900)
+#define snprintf _snprintf
--- End diff --
One of our goals early on was to maintain latest version and not try and
support everything available as it would become too difficult to maintain. What
is the minimum set here that is in LTS, I would say we try and cover latest and
possible one or two back (if that)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
