Github user ben-craig commented on the issue:

    https://github.com/apache/thrift/pull/1103
  
    PlatformThreadFactory f;
    f.setDetached(false);
    
    Prior to this change, that was the only way to portably change the detached 
state.  The PosixThreadFactory didn't have a ctor that would permit that.  The 
tests were even using this pattern.
    
    I see that you have added a PosixThreadFactory ctor that lets you set the 
detached state in a portable way, and that's great.  It doesn't change that 
this pattern is already out there in a lot of production code.  It even broke 
tests which made no use of ThreadManager.
    
    If you need to fix the tests after making a change, chances are high that 
you have introduced a source breaking change that needs to be strongly 
considered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to