[
https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043451#comment-16043451
]
Can Celasun commented on THRIFT-4219:
-------------------------------------
[~jmrdi] I agree that the current situation is confusing.
In fact, I'm not sure why {{NewTHttpClient}} client is needed at all, i.e what
is the use case for having a one-off client making {{GET}} requests?
Maybe we should remove the current {{NewTHttpClient}} and have a single
constructor with the {{POST}} behaviour. Anyone who needs the {{GET}} behaviour
(can't imagine why) can just implement {{TTransport}} themselves. This would
also allow us to clean up {{THttpClient}} and {{THttpClientTransportFactory}} a
bit and get rid of nil checks around {{requestBuffer}}.
[~jensg] Thoughts?
> Golang Http Clients Created with Nil Buffer
> -------------------------------------------
>
> Key: THRIFT-4219
> URL: https://issues.apache.org/jira/browse/THRIFT-4219
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: James Mouradian
>
> As of 2b1b32c,
> [{{NewTHttpClientWithOptions}}|https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go#L93]
> creates a {{THttpClient}} instance with a nil {{requestBuffer}}. This causes
> a panic when the instance attempts to write to the buffer.
> A patch probably fits well with THRIFT-4215 and THRIFT-4216.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
