[
https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045586#comment-16045586
]
ASF GitHub Bot commented on THRIFT-4219:
----------------------------------------
GitHub user dcelasun opened a pull request:
https://github.com/apache/thrift/pull/1287
THRIFT-4219 Refactor Go HTTP Client
As discussed in THRIFT-4219, this commit removes support for one-off GET
requests, which brings the Go HTTP client inline with implementations in
other languages.
Constructor functions with "Post" in their names are all deprecated
using the proper format [0] as all constructors now have the POST
behaviour.
Fixes THRIFT-4219.
[0] https://github.com/golang/go/issues/10909#issuecomment-136492606
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dcelasun/thrift THRIFT-4219
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1287.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1287
----
commit fdbf25f5f802fc9fde926b61c0fd31f95e39d000
Author: D. Can Celasun <[email protected]>
Date: 2017-06-10T14:37:47Z
THRIFT-4219 Refactor Go HTTP Client
As discussed in THRIFT-4219, this commit removes support for one-off GET
requests, which brings the Go HTTP client inline with implementations in
other languages.
Constructor functions with "Post" in their names are all deprecated
using the proper format [0] as all constructors now have the POST
behaviour.
Fixes THRIFT-4219.
[0] https://github.com/golang/go/issues/10909#issuecomment-136492606
----
> Golang HTTP clients created with Nil buffer
> -------------------------------------------
>
> Key: THRIFT-4219
> URL: https://issues.apache.org/jira/browse/THRIFT-4219
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: James Mouradian
> Assignee: Can Celasun
>
> As of 2b1b32c,
> [{{NewTHttpClientWithOptions}}|https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go#L93]
> creates a {{THttpClient}} instance with a nil {{requestBuffer}}. This causes
> a panic when the instance attempts to write to the buffer.
> A patch probably fits well with THRIFT-4215 and THRIFT-4216.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
