[
https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043522#comment-16043522
]
Jens Geyer commented on THRIFT-4219:
------------------------------------
The layout, behaviour and names of the methods at (especially) transport and
protocol levels are well-defined and consistent throughout the entire library.
We should not do anything that breaks consistency, as this is an important part
of the overall design.
{quote}
By that, I meant it may be worth investigating the THttpClient transport
holistically, as there may be some other unresolved issues.
{quote}
That may be the case. Good idea.
{quote}
Maybe we should remove the current NewTHttpClient and have a single constructor
with the POST behaviour
{quote}
IIRC all other languages use POST only with HTTP. Should be double-checked, but
I'm pretty sure.
> Golang Http Clients Created with Nil Buffer
> -------------------------------------------
>
> Key: THRIFT-4219
> URL: https://issues.apache.org/jira/browse/THRIFT-4219
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: James Mouradian
>
> As of 2b1b32c,
> [{{NewTHttpClientWithOptions}}|https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go#L93]
> creates a {{THttpClient}} instance with a nil {{requestBuffer}}. This causes
> a panic when the instance attempts to write to the buffer.
> A patch probably fits well with THRIFT-4215 and THRIFT-4216.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
