[
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165185#comment-16165185
]
James E. King, III commented on THRIFT-4064:
--------------------------------------------
I tried to re-apply the pull request and run make check in the ubuntu-xenial
image.
I found this is happening:
{noformat}
root@a588b4cf0ace:/thrift/src/lib/nodejs#
NODE_PATH=/thrift/src/lib/nodejs/test:/thrift/src/lib/nodejs/test/../lib node
/thrift/src/lib/nodejs/test/browser_client.js
TAP version 13
# NodeJS Style Callback Client Tests
/thrift/src/lib/nodejs/lib/thrift/xhr_connection.js:84
throw "Your browser doesn't support XHR.";
^
Your browser doesn't support XHR.
{noformat}
Perhaps that will help someone else get started. To make it fail faster I
moved the call to testBrowser above the integration tests when I was working on
it.
> Update node library dependencies
> --------------------------------
>
> Key: THRIFT-4064
> URL: https://issues.apache.org/jira/browse/THRIFT-4064
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.10.0
> Reporter: Andres Suarez
> Labels: security-issue
>
> [email protected] is really old and presents issues for users using modern versions
> of Node (see
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should
> be updated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
