[
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166912#comment-16166912
]
ASF GitHub Bot commented on THRIFT-4064:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1359
I found grunt-jsdoc had a recent update; I changed the lib/js packages.json
to require the 2.1.1 version or later, as they had a dependency issue with
other packages that popped up. When I ran npm install, it downrevved jsdoc
from 3.5.4 to 3.4.3. Let's see if that makes a difference.
> Update node library dependencies
> --------------------------------
>
> Key: THRIFT-4064
> URL: https://issues.apache.org/jira/browse/THRIFT-4064
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.10.0
> Reporter: Andres Suarez
> Assignee: James E. King, III
> Labels: security-issue
>
> [email protected] is really old and presents issues for users using modern versions
> of Node (see
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should
> be updated.
> In the third pull request, here are the dependencies:
> node-int64 ~0.4.0
> q ~1.5.0
> ws >= 2.2.3 which implies node >= 4.1.0
> (https://github.com/websockets/ws/tree/2.2.3)
> On the ubuntu-xenial image which uses node v8.4.0 and npm 5.3.0, and on the
> centos-7.3 image which uses node v6.11.1 and npm 3.10.10 you end up with the
> following packages:
> {noformat}
> root@ddb384ee75a5:/thrift/src/lib/nodejs# npm list --depth 0
> [email protected] /thrift/src
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> `-- [email protected]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
