[
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166653#comment-16166653
]
ASF GitHub Bot commented on THRIFT-4064:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1359
I don't get this...
```
Running "jsdoc:dist" (jsdoc) task
>> fs.js:1919
>> binding.copyFile(src, dest, flags);
>> ^
>>
>> Error: EISDIR: illegal operation on a directory, copyfile
'/thrift/src/lib/js/node_modules/jsdoc/templates/default/static/fonts/OpenSans-Bold-webfont.eot'
-> 'doc/fonts'
>> at Object.fs.copyFileSync (fs.js:1919:11)
>> at
/thrift/src/lib/js/node_modules/jsdoc/templates/default/publish.js:471:12
>> at Array.forEach (<anonymous>)
>> at Object.exports.publish
(/thrift/src/lib/js/node_modules/jsdoc/templates/default/publish.js:468:17)
>> at Object.module.exports.cli.generateDocs
(/thrift/src/lib/js/node_modules/jsdoc/cli.js:430:39)
>> at Object.module.exports.cli.processParseResults
(/thrift/src/lib/js/node_modules/jsdoc/cli.js:383:20)
>> at module.exports.cli.main
(/thrift/src/lib/js/node_modules/jsdoc/cli.js:227:14)
>> at Object.module.exports.cli.runCommand
(/thrift/src/lib/js/node_modules/jsdoc/cli.js:180:5)
>> at /thrift/src/lib/js/node_modules/jsdoc/jsdoc.js:103:9
>> at Object.<anonymous>
(/thrift/src/lib/js/node_modules/jsdoc/jsdoc.js:104:3)
>> at Module._compile (module.js:624:30)
>> at Object.Module._extensions..js (module.js:635:10)
>> at Module.load (module.js:545:32)
>> at tryModuleLoad (module.js:508:12)
>> at Function.Module._load (module.js:500:3)
>> at Function.Module.runMain (module.js:665:10)
```
I even tried using a "mkdir -p doc/fonts" before running the grunt command
in the makefile in case doc/fonts is a file. I haven't been able to reproduce
this elsewhere; I'm going to start with a clean git clone and checkout this
branch. This error is present in all the recent builds, especially on job 4
which runs all the unit tests.
> Update node library dependencies
> --------------------------------
>
> Key: THRIFT-4064
> URL: https://issues.apache.org/jira/browse/THRIFT-4064
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.10.0
> Reporter: Andres Suarez
> Assignee: James E. King, III
> Labels: security-issue
>
> [email protected] is really old and presents issues for users using modern versions
> of Node (see
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should
> be updated.
> In the third pull request, here are the dependencies:
> node-int64 ~0.4.0
> q ~1.5.0
> ws >= 2.2.3 which implies node >= 4.1.0
> (https://github.com/websockets/ws/tree/2.2.3)
> On the ubuntu-xenial image which uses node v8.4.0 and npm 5.3.0, and on the
> centos-7.3 image which uses node v6.11.1 and npm 3.10.10 you end up with the
> following packages:
> {noformat}
> root@ddb384ee75a5:/thrift/src/lib/nodejs# npm list --depth 0
> [email protected] /thrift/src
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> +-- [email protected]
> `-- [email protected]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
