[ 
https://issues.apache.org/jira/browse/THRIFT-5347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280995#comment-17280995
 ] 

Max commented on THRIFT-5347:
-----------------------------

Hey all! Let me first notice that supporting almost 30 libraries each in a 
different language, all under the single repository/package, creates rather 
heavy maintenance load. I'm saying that not to diminish or disvalue the titanic 
effort by [~jensg] and others (that'd be a crime) — I'm trying to suggest that 
splitting the per-language libraries off to separate repos may foster better 
structure of communication, leading to easier maintenance.

But. Such a split wouldn't be ergonomic for some languages (e.g. in C++ it's 
just too easy to directly include Thrift's headers and be done with it, 
nevermind the tight coupling) up to the point of being impossible (where 
codegen is coupled to specific "intrinsics" in the target language's library).

However Haskell is powerful enough to handle Thrift standalone, as 
demonstrated. Perhaps it's best to deprecate the conventional "dumb" code 
generation as is done in Thrift's compiler, and instead endorse standalone 
solutions as above.

Just one thing worries me: CI matters and the cross-language testing. I don't 
think our CI is currently adapted to test standalone-style libraries, so 
migrating there would mean losing the cross-language coverage. Any ideas?

 

> Haskell library not production-ready
> ------------------------------------
>
>                 Key: THRIFT-5347
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5347
>             Project: Thrift
>          Issue Type: Brainstorming
>          Components: Haskell - Library
>            Reporter: Philipp Hausmann
>            Assignee: Jens Geyer
>            Priority: Major
>             Fix For: 0.15.0
>
>
> I personally consider the thrift Haskell library not production ready due to 
> e.g. THRIFT-5098 and THRIFT-5231. I would recommend that you instead suggest 
> that people use one of the following two alternative implementations:
>  
> hsthrift:
> [https://github.com/facebookincubator/hsthrift]
>  
> pinch/pinch-gen:
> [https://github.com/abhinav/pinch#readme]
> [https://github.com/phile314/pinch-gen/]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to