[ 
https://issues.apache.org/jira/browse/THRIFT-5347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281025#comment-17281025
 ] 

Philipp Hausmann commented on THRIFT-5347:
------------------------------------------

I might should have expanded the issue description a bit more, but I highly 
appreciate the fact that we have thrift and bindings for so many languages! 
Thanks to everybody involved.

 

My main motivation for opening this issue is that the thrift website ( 
[https://thrift.apache.org/lib/] ) currently directs Haskell develop to the 
Haskell thrift library which is part of Apache Thrift. However, I consider both 
hsthrift and pinch/pinch-gen to be technically superior both in implementation 
quality and in that they expose a more haskell-y interface. Additionally, they 
are both actively maintained. So I think Haskell developers looking for Thrift 
bindings should be directed towards those two libraries. In which form that is 
done (deprecation, note on the web page, something else...) is of course up for 
debate.

 

I think whether those libraries should become part of Apache Thrift is an 
orthogonal issue, and I am not sure there is significant value in moving those 
packages. I also have no idea if the authors would be interested in that. Pinch 
specifically also has an extensive test suite and as the Thrift protocol is 
quite stable, I think it is not more work to maintain it separately. As a bonus 
point, this also takes some effort off from your shoulders ;)

 

Personally I am in favor of deprecating the Apache Thrift Haskell library as I 
think it cannot be salvaged without major changes. And as there are already two 
perfectly good libraries, I don't think that's worth the effort.

 

I guess there is still the valid point Max raises on how to test cross-language 
compatibility, but that feels like a much larger problem not specific to 
Haskell.

> Haskell library not production-ready
> ------------------------------------
>
>                 Key: THRIFT-5347
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5347
>             Project: Thrift
>          Issue Type: Brainstorming
>          Components: Haskell - Library
>            Reporter: Philipp Hausmann
>            Assignee: Jens Geyer
>            Priority: Major
>             Fix For: 0.15.0
>
>
> I personally consider the thrift Haskell library not production ready due to 
> e.g. THRIFT-5098 and THRIFT-5231. I would recommend that you instead suggest 
> that people use one of the following two alternative implementations:
>  
> hsthrift:
> [https://github.com/facebookincubator/hsthrift]
>  
> pinch/pinch-gen:
> [https://github.com/abhinav/pinch#readme]
> [https://github.com/phile314/pinch-gen/]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to