kpumuk commented on code in PR #21:
URL: https://github.com/apache/thrift-website/pull/21#discussion_r3177315186
##########
static/css/new-fonts.css:
##########
@@ -0,0 +1,45 @@
+@font-face {
+ font-family: "Open Sans";
+ font-display: fallback;
+ font-style: normal;
+ font-weight: 400;
+ src: url(/static/fonts/OpenSans-Regular.ttf) format("truetype");
+}
+@font-face {
+ font-family: "Open Sans";
+ font-display: fallback;
+ font-style: normal;
+ font-weight: 700;
+ src: url(/static/fonts/OpenSans-Bold.ttf) format("truetype");
+}
+
+@font-face {
+ font-family: "Montserrat";
+ font-display: fallback;
+ font-style: normal;
+ font-weight: 300;
+ src: url(/static/fonts/JTUHjIg1_i6t8kCHKm4532VJOt5-QNFgpCs16Hw5aX8.ttf)
+ format("truetype");
+}
+@font-face {
+ font-family: "Montserrat";
+ font-display: fallback;
+ font-style: normal;
+ font-weight: 600;
+ src: url(/static/fonts/JTUHjIg1_i6t8kCHKm4532VJOt5-QNFgpCu173w5aX8.ttf)
Review Comment:
Wonder what's up with the name of the font. According to the branding guide,
it should be downloaded from Google Fonts
https://fonts.google.com/specimen/Montserrat
##########
_includes/header.html:
##########
@@ -1,30 +1,23 @@
-<div class="navbar">
- <div class="navbar-inner">
- <div class="container">
- <a class="brand" href="/">Apache Thrift ™</a>
- <div class="nav-collapse">
- <ul class="nav pull-right">
- <li><a href="/download">Download</a></li>
- <li><a href="/docs">Documentation</a></li>
- <li><a href="/developers">Developers</a></li>
- <li><a href="/lib">Libraries</a></li>
- <li><a href="/tutorial">Tutorial</a></li>
- <li><a href="/test">Test Suite</a></li>
- <li><a href="/about">About</a></li>
- <li class="dropdown">
- <a href="#" class="dropdown-toggle" data-toggle="dropdown">Apache
<b class="caret"></b></a>
- <ul class="dropdown-menu">
- <li><a href="https://www.apache.org/"; target="_blank">Apache
Home</a></li>
- <li><a href="https://www.apache.org/licenses/";
target="_blank">License</a></li>
- <li><a href="https://www.apache.org/foundation/sponsorship.html";
target="_blank">Donate</a></li>
- <li><a href="https://events.apache.org/";
target="_blank">Events</a></li>
- <li><a href="https://www.apache.org/foundation/thanks.html";
target="_blank">Thanks</a></li>
- <li><a href="https://www.apache.org/security/";
target="_blank">Security</a></li>
- <li><a
href="https://privacy.apache.org/policies/privacy-policy-public.html";
target="_blank">Privacy</a></li>
- </ul>
- </li>
- </ul>
- </div>
- </div>
+<header id="top-header" data-pagefind-ignore="all">
+ <div class="header-banner"></div>
+ <div class="inner text-center py-medium">
+ <a href="/" class="logo">
+ <img
+ src="/static/images/logo_thrift_color.svg"
Review Comment:
Interesting, brand guide says
> The ASF oak leaf may be incorporated in ASF project logos provided that it
adheres to the following guidelines.
> https://apache.org/foundation/press/kit/ApacheFoundation_StyleGuide.pdf
It still is not incorporated though.
##########
_includes/header.html:
##########
@@ -1,30 +1,23 @@
-<div class="navbar">
- <div class="navbar-inner">
- <div class="container">
- <a class="brand" href="/">Apache Thrift ™</a>
- <div class="nav-collapse">
- <ul class="nav pull-right">
- <li><a href="/download">Download</a></li>
- <li><a href="/docs">Documentation</a></li>
- <li><a href="/developers">Developers</a></li>
- <li><a href="/lib">Libraries</a></li>
- <li><a href="/tutorial">Tutorial</a></li>
- <li><a href="/test">Test Suite</a></li>
- <li><a href="/about">About</a></li>
- <li class="dropdown">
- <a href="#" class="dropdown-toggle" data-toggle="dropdown">Apache
<b class="caret"></b></a>
- <ul class="dropdown-menu">
- <li><a href="https://www.apache.org/"; target="_blank">Apache
Home</a></li>
- <li><a href="https://www.apache.org/licenses/";
target="_blank">License</a></li>
- <li><a href="https://www.apache.org/foundation/sponsorship.html";
target="_blank">Donate</a></li>
- <li><a href="https://events.apache.org/";
target="_blank">Events</a></li>
- <li><a href="https://www.apache.org/foundation/thanks.html";
target="_blank">Thanks</a></li>
- <li><a href="https://www.apache.org/security/";
target="_blank">Security</a></li>
- <li><a
href="https://privacy.apache.org/policies/privacy-policy-public.html";
target="_blank">Privacy</a></li>
- </ul>
- </li>
- </ul>
- </div>
- </div>
+<header id="top-header" data-pagefind-ignore="all">
+ <div class="header-banner"></div>
+ <div class="inner text-center py-medium">
+ <a href="/" class="logo">
+ <img
+ src="/static/images/logo_thrift_color.svg"
Review Comment:
Wonder where the logo came from. ASF has pretty string branding guidelines,
that prohibit modifying logos and attaching the leaf to different things ;-)
* https://apache.org/foundation/marks/
* https://apache.org/logos/?#thrift
##########
_includes/footer.html:
##########
@@ -1,32 +1,133 @@
-<div class="container">
- <hr>
- <footer class="footer">
- <div class="row">
- <div class="span3">
- <h3>Links</h3>
- <ul class="unstyled">
- <li><a href="/download">Download</a></li>
- <li><a href="/developers">Developers</a></li>
- <li><a href="/tutorial">Tutorials</a></li>
- </ul>
- <ul class="unstyled">
- <li><a href="/sitemap">Sitemap</a></li>
- </ul>
+<footer class="footer">
+ <div class="inner py-xl">
+ <div class="flex gap mb-lg flex-col md:flex-row">
+ <div class="flex-1 flex flex-col gap">
+ <img
+ src="/static/images/asf_logo_full_horizontal_white.svg"
+ width="300"
+ alt="ASF White Logo"
+ />
+ <p>
+ Apache, Apache Thrift and the Apache logo are trademarks of
+ <a href="https://www.apache.org";>The Apache Software Foundation</a>
+ </p>
</div>
- <div class="span3">
- <h3>Get Involved</h3>
- <ul class="unstyled">
- <li><a href="/mailing">Mailing Lists</a></li>
- <li><a href="{{ site.jira_url }}">Issue Tracking</a></li>
- <li><a href="/docs/HowToContribute">How To Contribute</a></li>
- </ul>
- </div>
- <div class="span6">
- <a href="http://www.apache.org/";><img src="/static/images/feather.svg"
onerror="this.src='/static/images/feather.png';this.onerror=null;" width="32"
/></a>
- Copyright © {{ 'now' | date: "%Y" }} <a
href="http://www.apache.org/";>Apache Software Foundation</a>.
- Licensed under the <a href="http://www.apache.org/licenses/";>Apache
License v2.0</a>.
- Apache, Apache Thrift, and the Apache feather logo are trademarks of
The Apache Software Foundation.
+ <div class="flex-1 flex gap-medium">
+ <div class="flex flex-col flex-1">
+ <div class="footer-nav-group">
+ <h5>Resources</h5>
+ <ul class="list-unstyled" role="menu">
+ <li role="none">
+ <a role="menuitem" href="/docs/">Docs</a>
+ </li>
+ <li role="none">
+ <a href="/tutorial/">Guides</a>
+ </li>
+ <li role="none">
+ <a role="menuitem" href="/download">Download</a>
+ </li>
+ <li role="none">
+ <a role="menuitem" href="/changelog">Changelog</a>
+ </li>
+ <li role="none">
+ <a role="menuitem" href="/lib/">Libraries</a>
+ </li>
+ <li role="none">
+ <a href="/static/files/thrift-20070401.pdf">Whitepaper</a>
+ </li>
+ </ul>
+ </div>
+ </div>
+ <div class="flex flex-col flex-1">
+ <div class="footer-nav-group">
+ <h5>Community</h5>
+ <ul class="list-unstyled" role="menu">
+ <li role="none">
+ <a role="menuitem" href="/mailing"> Mailing Lists </a>
+ </li>
+ <li role="none">
+ <a role="menuitem" href="{{ site.jira_url }}" target="_blank">
+ Issue Tracking
+ </a>
+ </li>
+ <li role="none">
+ <a role="menuitem" href="/docs/HowToContribute"
target="_blank">
Review Comment:
Does not have to open in a new tab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
