kpumuk commented on code in PR #21:
URL: https://github.com/apache/thrift-website/pull/21#discussion_r3177425829
##########
static/css/new-fonts.css:
##########
@@ -0,0 +1,45 @@
+@font-face {
+ font-family: "Open Sans";
+ font-display: fallback;
+ font-style: normal;
+ font-weight: 400;
+ src: url(/static/fonts/OpenSans-Regular.ttf) format("truetype");
+}
+@font-face {
+ font-family: "Open Sans";
+ font-display: fallback;
+ font-style: normal;
+ font-weight: 700;
+ src: url(/static/fonts/OpenSans-Bold.ttf) format("truetype");
+}
+
+@font-face {
+ font-family: "Montserrat";
+ font-display: fallback;
+ font-style: normal;
+ font-weight: 300;
+ src: url(/static/fonts/JTUHjIg1_i6t8kCHKm4532VJOt5-QNFgpCs16Hw5aX8.ttf)
+ format("truetype");
+}
+@font-face {
+ font-family: "Montserrat";
+ font-display: fallback;
+ font-style: normal;
+ font-weight: 600;
+ src: url(/static/fonts/JTUHjIg1_i6t8kCHKm4532VJOt5-QNFgpCu173w5aX8.ttf)
Review Comment:
Interesting. Those are named `MontserratThin-Light` and
`MontserratThin-SemiBold`. They are also much smaller (40kb vs 350kb). The
guide says:
> Headings are to be in Montserrat Bold.
> Subheaders use Montserrat Light.
We should probably download fonts from Google and use `Montserrat-Bold.ttf`
and `Montserrat-Light.ttf` consistently, and drop the `MontserratThin`
completely. The Apache website uses bold for all headings though...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
