kpumuk commented on code in PR #21: URL: https://github.com/apache/thrift-website/pull/21#discussion_r3178094206
########## _includes/header.html: ########## @@ -1,30 +1,23 @@ -<div class="navbar"> - <div class="navbar-inner"> - <div class="container"> - <a class="brand" href="/">Apache Thrift ™</a> - <div class="nav-collapse"> - <ul class="nav pull-right"> - <li><a href="/download">Download</a></li> - <li><a href="/docs">Documentation</a></li> - <li><a href="/developers">Developers</a></li> - <li><a href="/lib">Libraries</a></li> - <li><a href="/tutorial">Tutorial</a></li> - <li><a href="/test">Test Suite</a></li> - <li><a href="/about">About</a></li> - <li class="dropdown"> - <a href="#" class="dropdown-toggle" data-toggle="dropdown">Apache <b class="caret"></b></a> - <ul class="dropdown-menu"> - <li><a href="https://www.apache.org/"; target="_blank">Apache Home</a></li> - <li><a href="https://www.apache.org/licenses/"; target="_blank">License</a></li> - <li><a href="https://www.apache.org/foundation/sponsorship.html"; target="_blank">Donate</a></li> - <li><a href="https://events.apache.org/"; target="_blank">Events</a></li> - <li><a href="https://www.apache.org/foundation/thanks.html"; target="_blank">Thanks</a></li> - <li><a href="https://www.apache.org/security/"; target="_blank">Security</a></li> - <li><a href="https://privacy.apache.org/policies/privacy-policy-public.html"; target="_blank">Privacy</a></li> - </ul> - </li> - </ul> - </div> - </div> +<header id="top-header" data-pagefind-ignore="all"> + <div class="header-banner"></div> + <div class="inner text-center py-medium"> + <a href="/" class="logo"> + <img + src="/static/images/logo_thrift_color.svg" Review Comment: https://apache.org/logos/?#thrift is the only logo Thrift ever had. Oak leaf is a foundational logo, which can be incorporated into ASF project logos, but I would think Apache Thrift PMC would have a final say in the layout of the new version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
