NilsGriebner opened a new pull request, #47:
URL: https://github.com/apache/tika-helm/pull/47
## Summary
Add a `podLabels` value that lets users attach extra labels to the Tika pods.
## Motivation
The chart supports `podAnnotations` but has no way to set additional labels
on the pod template; `deployment.yaml` only renders `tika-helm.selectorLabels`.
Labels are what label selectors, monitoring (e.g. kube-state-metrics
`kube_pod_labels`), cost allocation and network policies key on, so annotations
are not a substitute.
## Changes
- `values.yaml`: new `podLabels: {}`
- `templates/deployment.yaml`: render `podLabels` after the selector labels
on the pod template
- `values.schema.json`: add `podLabels` (`additionalProperties: true` so
arbitrary keys validate)
- `README.md`: document the new value
- `tests/deployment_test.yaml`: add a test that custom labels are set and
the selector labels are preserved
Default behaviour is unchanged: with `podLabels: {}` the rendered output is
identical.
## Testing
- `helm lint .`
- `helm template t . --set podLabels.contact/purpose=prod` renders the label
on `spec.template.metadata.labels`, next to `app.kubernetes.io/name` and
`app.kubernetes.io/instance`
- `helm template t .` renders no extra labels
## Note
`values.schema.json` sets `additionalProperties: false` on `podAnnotations`
(and `nodeSelector`), so setting any key on them currently fails schema
validation, e.g. `--set podAnnotations.a=b`. That is outside this PR, but I'm
happy to fix it separately.
Edit "Testing" if you run the new unit test with helm unittest. I didn't, so
I haven't claimed it passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
