NilsGriebner commented on PR #47:
URL: https://github.com/apache/tika-helm/pull/47#issuecomment-6443013546
Thanks, both points are valid and I reproduced them. I pushed 0bf050a to
this PR:
- Schema: `podLabels` now uses `additionalProperties: {"type": "string"}`.
`--set podLabels.team=true` fails at template time (`got boolean, want
string`); `--set-string podLabels.team=true` renders `team: "true"`. Before,
the unquoted bool passed lint and a server-side dry-run rejected it (`cannot
unmarshal bool ... of type string`).
- Selector collision: the pod labels are now `merge`d with the selector
labels, selector labels taking precedence, so `app.kubernetes.io/name` is
emitted once and the pod keeps matching the Deployment selector. Before, it was
emitted twice with the custom value last.
- Tests: added a case for each. I ran the equivalent `helm template`
commands and `helm lint` locally, but have not run `helm unittest`.
Side effect: the pod template labels are now rendered sorted by key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
