tballison commented on PR #47:
URL: https://github.com/apache/tika-helm/pull/47#issuecomment-6442461136
My :robot: recommends:
```
- Restrict values to strings in the schema. Right now it uses
additionalProperties: true. Kubernetes label
values must be strings, and --set podLabels.team=true (or =123) gives an
unquoted bool or int. That passes the
schema and lint, then the API server rejects it at install time. Using
"additionalProperties": {"type":
"string"} catches it at template time.
- Selector-key collisions. If someone sets
podLabels."app.kubernetes.io/name", the label is emitted twice. The
later value wins, so the pod labels no longer match the Deployment
selector and the install fails with an
opaque "selector does not match template labels" error. Common charts
handle this with merge (selector labels
take precedence) or by documenting it. This one is minor and can wait
for a follow-up.
```
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
