[ 
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569180#comment-15569180
 ] 

ASF GitHub Bot commented on TINKERPOP-1493:
-------------------------------------------

Github user pauljackson commented on the issue:

    https://github.com/apache/tinkerpop/pull/456
  
    There’s more differences than just the comments at the head of these files, 
so you could copy them from 3.2.3 if you are ok with those changes.
    
    
    From: Jason Plurad [mailto:notificati...@github.com]
    Sent: Wednesday, October 12, 2016 12:27 PM
    To: apache/tinkerpop
    Cc: Paul A. Jackson; Author
    Subject: Re: [apache/tinkerpop] TINKERPOP-1493 Groovy project doesn't build 
on Windows (#456)
    
    
    One problem I'm seeing is that RAT doesn't like these files on Windows:
    
    Unapproved licenses:
    
    
    
      bin/gremlin.sh
    
      gremlin-console/bin/gremlin.sh
    
    No complaints from Linux/Mac since they resolve OK with the 
symlinks<https://github.com/apache/tinkerpop/pull/444>. On Windows, they get 
extracted as files with content:
    
    ../gremlin-console/bin/gremlin.sh
    
    
    
    
../target/apache-tinkerpop-gremlin-console-3.2.3-SNAPSHOT-standalone/bin/gremlin.sh
    
    —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on 
GitHub<https://github.com/apache/tinkerpop/pull/456#issuecomment-253264393>, or 
mute the 
thread<https://github.com/notifications/unsubscribe-auth/AAUcSH2lUoBrOHNFVn25qvXFlG6oP7Wbks5qzQpxgaJpZM4KUD8k>.
    
    ________________________________
    



> Groovy project doesn't build on Windows
> ---------------------------------------
>
>                 Key: TINKERPOP-1493
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: groovy
>    Affects Versions: 3.2.2
>            Reporter: Paul Jackson
>            Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir 
> is creating a path consisting of two full paths concatenated together. The 
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new 
> File(System.getProperty("user.dir"), 
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is 
> because some instances of JarFile are created on it but not closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to