[ 
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570624#comment-15570624
 ] 

ASF GitHub Bot commented on TINKERPOP-1493:
-------------------------------------------

GitHub user pauljackson opened a pull request:

    https://github.com/apache/tinkerpop/pull/457

    TINKERPOP-1493 Groovy project doesn't build on Windows

    Removed support for user.dir property as it was being prepended to a
    fully qualified path and the second drive letter was making the path
    illegal.
    
    Made sure JarFile instances were being closed so that Groovy could
    delete the directory without encountering file locked errors.
    
    Exclude Unix scripts from RAT plugin
    
    Tinkergraph integration tests fail but can build when skipping
    integration tests. Hadoop fails either way. Could be environmental on my
    end.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pauljackson/tinkerpop tp31

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #457
    
----
commit 47da7536a207610024d0497167ae7e800739d23b
Author: PaulJackson123 <pauljackson...@verizon.net>
Date:   2016-10-13T02:41:17Z

    TINKERPOP-1493 Groovy project doesn't build on Windows
    
    Removed support for user.dir property as it was being prepended to a
    fully qualified path and the second drive letter was making the path
    illegal.
    
    Made sure JarFile instances were being closed so that Groovy could
    delete the directory without encountering file locked errors.
    
    Exclude Unix scripts from RAT plugin
    
    Tinkergraph integration tests fail but can build when skipping
    integration tests. Hadoop fails either way. Could be environmental on my
    end.

----


> Groovy project doesn't build on Windows
> ---------------------------------------
>
>                 Key: TINKERPOP-1493
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: groovy
>    Affects Versions: 3.2.2
>            Reporter: Paul Jackson
>            Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir 
> is creating a path consisting of two full paths concatenated together. The 
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new 
> File(System.getProperty("user.dir"), 
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is 
> because some instances of JarFile are created on it but not closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to