ASF GitHub Bot commented on TINKERPOP-1493:

Github user pluradj commented on the issue:

    RAT exclusion works. A Windows user shouldn't be touching those symbolic 
links anyway.
    diff --git a/pom.xml b/pom.xml
    index 2e67eda..5351689 100644
    --- a/pom.xml
    +++ b/pom.xml
    @@ -293,6 +293,8 @@ limitations under the License.
    +                        <exclude>bin/gremlin.sh</exclude>
    +                        <exclude>gremlin-console/bin/gremlin.sh</exclude>
    @pauljackson Can you get the exclusions added in `pom.xml` to the PR and 
retarget it to `apache:tp31`?

> Groovy project doesn't build on Windows
> ---------------------------------------
>                 Key: TINKERPOP-1493
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: groovy
>    Affects Versions: 3.2.2
>            Reporter: Paul Jackson
>            Priority: Minor
> Builds on Windows fail for two reasons. First the line to create extTestDir 
> is creating a path consisting of two full paths concatenated together. The 
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new 
> File(System.getProperty("user.dir"), 
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is 
> because some instances of JarFile are created on it but not closed.

This message was sent by Atlassian JIRA

Reply via email to