[ https://issues.apache.org/jira/browse/TINKERPOP-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714043#comment-15714043 ]
ASF GitHub Bot commented on TINKERPOP-1539: ------------------------------------------- GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/511 TINKERPOP-1539 Create a ComplexTraversalTest with crazy nested gnarly traversals. https://issues.apache.org/jira/browse/TINKERPOP-1539 Added 2 more tests, one for OLTP only and one for OLTP+OLAP. More tests should not be added as part of this PR; we can add more later whenever a good traversal appears on the mailing list or somewhere else in the real world. `docker/build.sh -t -i -n` succeeded. VOTE: +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1539 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #511 ---- commit e01aa721fd13e6cb6591aa3f54314071e118a087 Author: Marko A. Rodriguez <okramma...@gmail.com> Date: 2016-11-28T22:49:08Z Got ComplexTest setup for @dkuppitz to go to town on. I don't think we need to include a GroovyComplexTest because @spmallette is doing the work for master/ that gets rid of the need for gremlin-groovy-test and thus, no need to waste the energy/time on GroovyComplexTest. commit c68b2154ddc83b5e11686a11588585e238ec2985 Author: Daniel Kuppitz <daniel_kupp...@hotmail.com> Date: 2016-12-01T21:13:59Z added two complex tests; one for OLTP only, one for OLTP and OLAP ---- > Create a ComplexTraversalTest with crazy nested gnarly traversals. > ------------------------------------------------------------------ > > Key: TINKERPOP-1539 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1539 > Project: TinkerPop > Issue Type: Improvement > Components: process, test-suite > Affects Versions: 3.2.3 > Reporter: Marko A. Rodriguez > Assignee: Daniel Kuppitz > > Our {{ProcessSuite}} has numerous tests verifying the semantics of the > various steps. Unfortunately, these tests are on simple traversals focused on > exposing the step in question in isolation. > It would be good to add {{ComplexTraversalTest}} to the {{ProcessSuite}} > which has traversals over the Grateful Dead graph (for complexity reasons) > doing: > 1. Numerous nests. > 2. Match/Select/Where complexities. > 3. Global side-effect access and unrolling and injecting. > 4. ... just a bunch of nasty stuff. > This will give us much more confidence as we add more strategies and > potentially, mess up our algebra which isn't exposed by the simple > "flat'-traversals we current test with. > [~dkuppitz] --- would you be interested in doing this? -- This message was sent by Atlassian JIRA (v6.3.4#6332)