[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169942#comment-16169942
]
ASF GitHub Bot commented on TINKERPOP-1785:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/716
TINKERPOP-1785 Added strong name signing for .NET components
https://issues.apache.org/jira/browse/TINKERPOP-1785
I guess we need strong naming for legacy support of this Microsoft feature.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1785
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/716.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #716
----
commit aac2dd7224b78ce4b1b089953a7b8d52e57880a8
Author: Stephen Mallette <[email protected]>
Date: 2017-09-18T12:22:21Z
TINKERPOP-1785 Added strong name signing for .NET components
----
> Gremlin.Net should be strong-name signed
> ----------------------------------------
>
> Key: TINKERPOP-1785
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1785
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.3.0, 3.2.6
> Reporter: Florian Hockmann
> Priority: Minor
>
> Users that strong-name sign their assemblies currently cannot use our
> Gremlin.Net NuGet packages as they are not strong-name signed as strong-named
> assemblies can only reference strong-named assemblies.
> I [just strong-name signed the pre-GLV
> version|https://github.com/FlorianHockmann/Gremlin.Net/pull/13] of
> Gremlin.Net as it [was requested by
> users|https://github.com/FlorianHockmann/Gremlin.Net/issues/12].
> More information about strong-naming:
> https://docs.microsoft.com/en-us/dotnet/framework/app-domains/strong-named-assemblies
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
