[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173247#comment-16173247
]
ASF GitHub Bot commented on TINKERPOP-1785:
-------------------------------------------
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/716#discussion_r139986227
--- Diff: gremlin-dotnet/glv/Gremlin.Net.csproj.template ---
@@ -25,7 +25,9 @@ limitations under the License.
</PropertyGroup>
<PropertyGroup Label="Package">
- <Version>${projectVersion}</Version>
+ <Version>$projectVersion</Version>
+ <FileVersion>$projectVersion.0</FileVersion>
--- End diff --
My suggestion was to replace this:
```xml
<Version>3.2.7-SNAPSHOT</Version>
<FileVersion>3.2.7.0</FileVersion>
<AssemblyVersion>3.2.0.0</AssemblyVersion>
```
by this:
```xml
<VersionPrefix>3.2.7</VersionPrefix>
<VersionSuffix>SNAPSHOT</VersionSuffix>
<FileVersion>3.2.7.0</FileVersion>
<AssemblyVersion>3.2.0.0</AssemblyVersion>
```
as the second option seems to be easier to generate, but both are
completely valid and we can stay with the first option when you already managed
to adapt the generation for that.
> Gremlin.Net should be strong-name signed
> ----------------------------------------
>
> Key: TINKERPOP-1785
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1785
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.3.0, 3.2.6
> Reporter: Florian Hockmann
> Priority: Minor
>
> Users that strong-name sign their assemblies currently cannot use our
> Gremlin.Net NuGet packages as they are not strong-name signed as strong-named
> assemblies can only reference strong-named assemblies.
> I [just strong-name signed the pre-GLV
> version|https://github.com/FlorianHockmann/Gremlin.Net/pull/13] of
> Gremlin.Net as it [was requested by
> users|https://github.com/FlorianHockmann/Gremlin.Net/issues/12].
> More information about strong-naming:
> https://docs.microsoft.com/en-us/dotnet/framework/app-domains/strong-named-assemblies
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
