[
https://issues.apache.org/jira/browse/TINKERPOP-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173227#comment-16173227
]
ASF GitHub Bot commented on TINKERPOP-1785:
-------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/716#discussion_r139980666
--- Diff: gremlin-dotnet/glv/Gremlin.Net.csproj.template ---
@@ -25,7 +25,9 @@ limitations under the License.
</PropertyGroup>
<PropertyGroup Label="Package">
- <Version>${projectVersion}</Version>
+ <Version>$projectVersion</Version>
+ <FileVersion>$projectVersion.0</FileVersion>
--- End diff --
ok - fixed `<FileVersion>` - i just did some regex. i didn't quite
understand the suggestion that @FlorianHockmann made, but I can adjust if you
guys determine it is right to do so. at least it builds now.
> Gremlin.Net should be strong-name signed
> ----------------------------------------
>
> Key: TINKERPOP-1785
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1785
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.3.0, 3.2.6
> Reporter: Florian Hockmann
> Priority: Minor
>
> Users that strong-name sign their assemblies currently cannot use our
> Gremlin.Net NuGet packages as they are not strong-name signed as strong-named
> assemblies can only reference strong-named assemblies.
> I [just strong-name signed the pre-GLV
> version|https://github.com/FlorianHockmann/Gremlin.Net/pull/13] of
> Gremlin.Net as it [was requested by
> users|https://github.com/FlorianHockmann/Gremlin.Net/issues/12].
> More information about strong-naming:
> https://docs.microsoft.com/en-us/dotnet/framework/app-domains/strong-named-assemblies
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
