Github user jorgebay commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/792#discussion_r167789173
  
    --- Diff: gremlin-dotnet/glv/generate.groovy ---
    @@ -48,7 +48,7 @@ def toCSharpTypeMap = ["Long": "long",
                            "TraversalMetrics": "E2",
                            "Traversal": "ITraversal",
                            "Traversal[]": "ITraversal[]",
    -                       "Predicate": "TraversalPredicate",
    +                       "Predicate": "object",
    --- End diff --
    
    I think we should use an interface `ILambda` similar to java's counterpart: 
https://github.com/apache/tinkerpop/blob/3.2.7/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/function/Lambda.java#L33
    
    `Lambda.Groovy()` and `Lambda.Python()` could return `ILambda` instances. 
That way we can have a compile type check for methods like `Filter()`, 
`Until()`, etc... to accept only `ILambda` instances.


---

Reply via email to