[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541984#comment-16541984 ]
ASF GitHub Bot commented on TINKERPOP-967: ------------------------------------------ Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202104896 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java --- @@ -43,6 +43,7 @@ private Traversal.Admin<S, S> repeatTraversal = null; private Traversal.Admin<S, ?> untilTraversal = null; private Traversal.Admin<S, ?> emitTraversal = null; + private String loopName = null; --- End diff -- This field should be included in `RepeatStep::hashCode()`. > Support nested-repeat() structures > ---------------------------------- > > Key: TINKERPOP-967 > URL: https://issues.apache.org/jira/browse/TINKERPOP-967 > Project: TinkerPop > Issue Type: Improvement > Components: process > Affects Versions: 3.1.0-incubating > Reporter: Marko A. Rodriguez > Assignee: Marko A. Rodriguez > Priority: Major > > All the internal plumbing is staged for this to happen, we just haven't gone > all the way. In short, a {{NESTED_LOOP}} traverser has an internal > {{loopStack}} where {{repeat(repeat())}} will have a {{loopStack}} of two. > The {{it.loops()}} checks of the internal repeat will always check the top of > the stack and when its done repeating will delete its counter off the top of > the stack. > [~dkuppitz]'s work on {{LoopStep}} will be backwards compatible. In > {{RepeatStep}} we will support: > {code} > repeat('a',out('knows').repeat('b',out('parent'))) > {code} > and thus, things like {{loops('a')}} as well as {{times('a',2)}}. Note that > naming the loop stack will be a super rare case as most people will just > assume standard nested looping semantics with a push/pop stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)