[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543575#comment-16543575 ]
ASF GitHub Bot commented on TINKERPOP-967: ------------------------------------------ Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202437245 --- Diff: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStepTest.java --- @@ -39,7 +39,9 @@ __.repeat(out()).times(3), __.repeat(out().as("x")).times(3), __.out().emit().repeat(out()).times(3), - __.repeat(out()).until(hasLabel("x")) + __.repeat(out()).until(hasLabel("x")), + __.repeat("a", __.out()).times(3), --- End diff -- Sorry, perhaps I should have been more clear on what kind of traversals to add here. Can you please also add `__.repeat(out()).times(3)`? Without the changes in `hashCode()` this traversal would have had the same hashCode as `__.repeat("a", out()).times(3)` and thus this test would have failed. I guess these two will still collide: ``` __.repeat("a", __.repeat("b", out())) __.repeat("b", __.repeat("a", out())) ``` ...but I can't think of a solution that doesn't involve any expensive method calls. > Support nested-repeat() structures > ---------------------------------- > > Key: TINKERPOP-967 > URL: https://issues.apache.org/jira/browse/TINKERPOP-967 > Project: TinkerPop > Issue Type: Improvement > Components: process > Affects Versions: 3.1.0-incubating > Reporter: Marko A. Rodriguez > Assignee: Marko A. Rodriguez > Priority: Major > > All the internal plumbing is staged for this to happen, we just haven't gone > all the way. In short, a {{NESTED_LOOP}} traverser has an internal > {{loopStack}} where {{repeat(repeat())}} will have a {{loopStack}} of two. > The {{it.loops()}} checks of the internal repeat will always check the top of > the stack and when its done repeating will delete its counter off the top of > the stack. > [~dkuppitz]'s work on {{LoopStep}} will be backwards compatible. In > {{RepeatStep}} we will support: > {code} > repeat('a',out('knows').repeat('b',out('parent'))) > {code} > and thus, things like {{loops('a')}} as well as {{times('a',2)}}. Note that > naming the loop stack will be a super rare case as most people will just > assume standard nested looping semantics with a push/pop stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)