ASF GitHub Bot commented on TINKERPOP-967:

Github user dkuppitz commented on a diff in the pull request:

    --- Diff: 
    @@ -32,6 +32,7 @@
         protected Object sack = null;
         protected short loops = 0;  // an optimization hack to use a short 
internally to save bits :)
    +    protected String loopName = null;
    --- End diff --
    Again, this should be included in `hashCode()`.

> Support nested-repeat() structures
> ----------------------------------
>                 Key: TINKERPOP-967
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-967
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.1.0-incubating
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>            Priority: Major
> All the internal plumbing is staged for this to happen, we just haven't gone 
> all the way. In short, a {{NESTED_LOOP}} traverser has an internal 
> {{loopStack}} where {{repeat(repeat())}} will have a {{loopStack}} of two. 
> The {{it.loops()}} checks of the internal repeat will always check the top of 
> the stack and when its done repeating will delete its counter off the top of 
> the stack.
> [~dkuppitz]'s work on {{LoopStep}} will be backwards compatible. In 
> {{RepeatStep}} we will support:
> {code}
> repeat('a',out('knows').repeat('b',out('parent')))
> {code}
> and thus, things like {{loops('a')}} as well as {{times('a',2)}}. Note that 
> naming the loop stack will be a super rare case as most people will just 
> assume standard nested looping semantics with a push/pop stack.

This message was sent by Atlassian JIRA

Reply via email to