[
https://issues.apache.org/jira/browse/TINKERPOP-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210988#comment-17210988
]
ASF GitHub Bot commented on TINKERPOP-2436:
-------------------------------------------
spmallette commented on pull request #1342:
URL: https://github.com/apache/tinkerpop/pull/1342#issuecomment-705621275
We had it this way purposely. because you might want to configure the server
with no graphs at all. I'd admit it an odd use case. I suppose we could think
about changing it. Perhaps users would be better served to know that their
graph configurations failed. If they wanted the corner use case to start with
no graphs at all I suppose they could provide their own `GraphManager` to allow
that (or perhaps we could provide that implementation ourselves as a utility).
Let's see if anyone else comments on this change and I'll put some more thought
to it. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The gremlin server starts even if all graphs instantiation has failed
> ---------------------------------------------------------------------
>
> Key: TINKERPOP-2436
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2436
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.8
> Reporter: Nicolas Trangosi
> Priority: Major
>
> Sometimes the gremlin server fails to open the graph due to backend failure.
> In this case, gremlin server starts even if could not serve any request as
> gremlin-groovy GremlinScriptEngine is not initialized. I think that in this
> case, gremlin server should stop (and be restarted in a kubernates cluster)
> {{8 Oct 2020 12:35:51,923 8660 [gremlin-server-exec-1] ERROR
> org.apache.tinkerpop.gremlin.jsr223.DefaultGremlinScriptEngineManager -
> Could not create GremlinScriptEngine for gremlin-groovy}}
> {{ java.lang.IllegalStateException: javax.script.ScriptException:
> javax.script.ScriptException: groovy.lang.MissingPropertyException: No such
> property: graph for class: Script1 }}
> {noformat}
> 08 Oct 2020 12:35:45,228 1965 [main] WARN
> org.apache.tinkerpop.gremlin.server.GremlinServer - Graph [graph] configured
> at [/etc/opt/janusgraph/janusgraph.properties] could not be instantiated and
> will not be available in Gremlin Server. GraphFactory message: GraphFactory
> could not instantiate this Graph implementation [class
> org.janusgraph.core.JanusGraphFactory]
> 08 Oct 2020 12:35:45,228 1965 [main] WARN
> org.apache.tinkerpop.gremlin.server.GremlinServer - Graph [graph] configured
> at [/etc/opt/janusgraph/janusgraph.properties] could not be instantiated and
> will not be available in Gremlin Server. GraphFactory message: GraphFactory
> could not instantiate this Graph implementation [class
> org.janusgraph.core.JanusGraphFactory]
> java.lang.RuntimeException: GraphFactory could not instantiate this Graph
> implementation [class org.janusgraph.core.JanusGraphFactory]
> at
> org.apache.tinkerpop.gremlin.structure.util.GraphFactory.open(GraphFactory.java:81)
> at
> org.apache.tinkerpop.gremlin.structure.util.GraphFactory.open(GraphFactory.java:69)
> at ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
