[
https://issues.apache.org/jira/browse/TINKERPOP-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216669#comment-17216669
]
ASF GitHub Bot commented on TINKERPOP-2436:
-------------------------------------------
spmallette commented on pull request #1342:
URL: https://github.com/apache/tinkerpop/pull/1342#issuecomment-712110239
This PR is looking pretty good. It looks like the only two issues from my
first review that are still outstanding are:
> 6. I presume throwing an exception will stop Gremlin Server from starting.
I don't think that breaks any of our integration tests because they all start
with configured graphs. I suppose you will find that out. We might want
integration tests for this change to ensure the server shuts down
nicely/cleanly, but let's see what the rest of these changes look like first.
I think an integration test would be good. We didn't have any "shutdown"
tests for you to use as a model so I quickly added one, which would probably a
good idea anyway, so you can add yours to that:
339551d2f080bd0d7756315643ed96da7dfff634
> 7. This is a breaking change in behavior so I think we will need Upgrade
Documentation for both users and providers on this PR.
We don't have a breaking change anymore since we kept the
`DefaultGraphManager` functionality untouched. If you like you can have this
functionality in 3.4.9 by re-targeting your PR to the `3.4-dev` branch
otherwise, feel free to leave it here on `master` for 3.5.0. In either case, I
think it would be nice to introduce this functionality in the `Upgrade
Documentation`. Adding that bit of extra documentation would nicely tidy this
PR up, but I'm happy to write that up on merge if you like.
As a final point of tidying, after you choose the branch you are aimed at,
please clean up the git history a bit and squash your commits down to one as we
prepare for a final merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The gremlin server starts even if all graphs instantiation has failed
> ---------------------------------------------------------------------
>
> Key: TINKERPOP-2436
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2436
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.8
> Reporter: Nicolas Trangosi
> Priority: Major
>
> Sometimes the gremlin server fails to open the graph due to backend failure.
> In this case, gremlin server starts even if could not serve any request as
> gremlin-groovy GremlinScriptEngine is not initialized. I think that in this
> case, gremlin server should stop (and be restarted in a kubernates cluster)
> {{8 Oct 2020 12:35:51,923 8660 [gremlin-server-exec-1] ERROR
> org.apache.tinkerpop.gremlin.jsr223.DefaultGremlinScriptEngineManager -
> Could not create GremlinScriptEngine for gremlin-groovy}}
> {{ java.lang.IllegalStateException: javax.script.ScriptException:
> javax.script.ScriptException: groovy.lang.MissingPropertyException: No such
> property: graph for class: Script1 }}
> {noformat}
> 08 Oct 2020 12:35:45,228 1965 [main] WARN
> org.apache.tinkerpop.gremlin.server.GremlinServer - Graph [graph] configured
> at [/etc/opt/janusgraph/janusgraph.properties] could not be instantiated and
> will not be available in Gremlin Server. GraphFactory message: GraphFactory
> could not instantiate this Graph implementation [class
> org.janusgraph.core.JanusGraphFactory]
> 08 Oct 2020 12:35:45,228 1965 [main] WARN
> org.apache.tinkerpop.gremlin.server.GremlinServer - Graph [graph] configured
> at [/etc/opt/janusgraph/janusgraph.properties] could not be instantiated and
> will not be available in Gremlin Server. GraphFactory message: GraphFactory
> could not instantiate this Graph implementation [class
> org.janusgraph.core.JanusGraphFactory]
> java.lang.RuntimeException: GraphFactory could not instantiate this Graph
> implementation [class org.janusgraph.core.JanusGraphFactory]
> at
> org.apache.tinkerpop.gremlin.structure.util.GraphFactory.open(GraphFactory.java:81)
> at
> org.apache.tinkerpop.gremlin.structure.util.GraphFactory.open(GraphFactory.java:69)
> at ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
