[
https://issues.apache.org/jira/browse/TINKERPOP-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216636#comment-17216636
]
ASF GitHub Bot commented on TINKERPOP-2436:
-------------------------------------------
spmallette commented on a change in pull request #1342:
URL: https://github.com/apache/tinkerpop/pull/1342#discussion_r507670096
##########
File path: docs/src/reference/gremlin-applications.asciidoc
##########
@@ -949,7 +949,7 @@ The following table describes the various YAML
configuration options that Gremli
|authentication.config |A `Map` of configuration settings to be passes to the
`Authenticator` when it is constructed. The settings available are dependent
on the implementation. |_none_
|authentication.enableAuditLog |The available authenticators can issue audit
logging messages, binding the authenticated user to his remote socket address
and binding requests with a gremlin query to the remote socket address. For
privacy reasons, the default value of this setting is false. The audit logging
messages are logged at the INFO level via the
`audit.org.apache.tinkerpop.gremlin.server` logger, which can be configured
using the log4j.properties file. |false
|channelizer |The fully qualified classname of the `Channelizer`
implementation to use. A `Channelizer` is a "channel initializer" which
Gremlin Server uses to define the type of processing pipeline to use. By
allowing different `Channelizer` implementations, Gremlin Server can support
different communication protocols (e.g. WebSocket). |`WebSocketChannelizer`
-|graphManager |The fully qualified classname of the `GraphManager`
implementation to use. A `GraphManager` is a class that adheres to the
TinkerPop `GraphManager` interface, allowing custom implementations for storing
and managing graph references, as well as defining custom methods to open and
close graphs instantiations. It is important to note that the TinkerPop HTTP
and WebSocketChannelizers auto-commit and auto-rollback based on the graphs
stored in the graphManager upon script execution completion.
|`DefaultGraphManager`
+|graphManager |The fully qualified classname of the `GraphManager`
implementation to use. A `GraphManager` is a class that adheres to the
TinkerPop `GraphManager` interface, allowing custom implementations for storing
and managing graph references, as well as defining custom methods to open and
close graphs instantiations. It is important to note that the TinkerPop HTTP
and WebSocketChannelizers auto-commit and auto-rollback based on the graphs
stored in the graphManager upon script execution completion. To prevent
gremlin-server to start when all graphs fails, the
`org.apache.tinkerpop.gremlin.server.util.CheckedGraphManager` can be
used.|`org.apache.tinkerpop.gremlin.server.util.DefaultGraphManager`
Review comment:
I'm afraid that using the full package name blows out the documentation
formatting pretty badly. Could you please remove that? If you feel it important
to have, then you can use a footnote of some sort and post the full package
name at the bottom of the table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The gremlin server starts even if all graphs instantiation has failed
> ---------------------------------------------------------------------
>
> Key: TINKERPOP-2436
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2436
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.8
> Reporter: Nicolas Trangosi
> Priority: Major
>
> Sometimes the gremlin server fails to open the graph due to backend failure.
> In this case, gremlin server starts even if could not serve any request as
> gremlin-groovy GremlinScriptEngine is not initialized. I think that in this
> case, gremlin server should stop (and be restarted in a kubernates cluster)
> {{8 Oct 2020 12:35:51,923 8660 [gremlin-server-exec-1] ERROR
> org.apache.tinkerpop.gremlin.jsr223.DefaultGremlinScriptEngineManager -
> Could not create GremlinScriptEngine for gremlin-groovy}}
> {{ java.lang.IllegalStateException: javax.script.ScriptException:
> javax.script.ScriptException: groovy.lang.MissingPropertyException: No such
> property: graph for class: Script1 }}
> {noformat}
> 08 Oct 2020 12:35:45,228 1965 [main] WARN
> org.apache.tinkerpop.gremlin.server.GremlinServer - Graph [graph] configured
> at [/etc/opt/janusgraph/janusgraph.properties] could not be instantiated and
> will not be available in Gremlin Server. GraphFactory message: GraphFactory
> could not instantiate this Graph implementation [class
> org.janusgraph.core.JanusGraphFactory]
> 08 Oct 2020 12:35:45,228 1965 [main] WARN
> org.apache.tinkerpop.gremlin.server.GremlinServer - Graph [graph] configured
> at [/etc/opt/janusgraph/janusgraph.properties] could not be instantiated and
> will not be available in Gremlin Server. GraphFactory message: GraphFactory
> could not instantiate this Graph implementation [class
> org.janusgraph.core.JanusGraphFactory]
> java.lang.RuntimeException: GraphFactory could not instantiate this Graph
> implementation [class org.janusgraph.core.JanusGraphFactory]
> at
> org.apache.tinkerpop.gremlin.structure.util.GraphFactory.open(GraphFactory.java:81)
> at
> org.apache.tinkerpop.gremlin.structure.util.GraphFactory.open(GraphFactory.java:69)
> at ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
