[ https://issues.apache.org/jira/browse/TINKERPOP-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221325#comment-17221325 ]
ASF GitHub Bot commented on TINKERPOP-2436: ------------------------------------------- spmallette commented on pull request #1342: URL: https://github.com/apache/tinkerpop/pull/1342#issuecomment-717169627 I noticed the travis issue with the jdk (which is why i was skeptical...i should have wrote that), but I'm building locally with: ```text $ mvn -version Apache Maven 3.6.0 Maven home: /usr/share/maven Java version: 1.8.0_242, vendor: AdoptOpenJDK, runtime: /home/smallette/.sdkman/candidates/java/8.0.242.hs-adpt/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.4.0-52-generic", arch: "amd64", family: "unix" ``` My errors are in Gremlin Server: ```text [ERROR] Errors: [ERROR] RemoteGraphGroovyTranslatorProcessComputerTest.initializationError ? Runtime j... [ERROR] RemoteGraphGroovyTranslatorProcessStandardTest.initializationError ? Runtime j... [ERROR] GraphBinaryRemoteGraphProcessComputerTest.initializationError ? Runtime java.u... [ERROR] GraphBinaryRemoteGraphProcessStandardTest.initializationError ? Runtime java.u... [ERROR] GraphSONRemoteGraphProcessComputerTest.initializationError ? Runtime java.util... [ERROR] GraphSONRemoteGraphProcessStandardTest.initializationError ? Runtime java.util... [ERROR] GryoRemoteGraphProcessComputerTest.initializationError ? Runtime java.util.con... [ERROR] GryoRemoteGraphProcessStandardTest.initializationError ? Runtime java.util.con... ``` They seem related to this stacktrace perhaps: ```text [ERROR] initializationError(org.apache.tinkerpop.gremlin.process.remote.GraphSONRemoteGraphProcessStandardTest) Time elapsed: 0.001 s <<< ERROR! java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.io.IOException: Could not bind to localhost and 45940 - perhaps something else is bound to that address. at org.apache.tinkerpop.gremlin.driver.remote.AbstractRemoteGraphProvider.<init>(AbstractRemoteGraphProvider.java:233) at org.apache.tinkerpop.gremlin.driver.remote.AbstractRemoteGraphProvider.<init>(AbstractRemoteGraphProvider.java:223) at org.apache.tinkerpop.gremlin.driver.remote.GraphSONRemoteGraphProvider.<init>(GraphSONRemoteGraphProvider.java:28) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at java.lang.Class.newInstance(Class.java:442) at org.apache.tinkerpop.gremlin.AbstractGremlinSuite.<init>(AbstractGremlinSuite.java:99) at org.apache.tinkerpop.gremlin.process.ProcessStandardSuite.<init>(ProcessStandardSuite.java:277) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.junit.internal.builders.AnnotatedBuilder.buildRunner(AnnotatedBuilder.java:107) at org.junit.internal.builders.AnnotatedBuilder.runnerForClass(AnnotatedBuilder.java:86) at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59) at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:26) at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59) at org.junit.internal.requests.ClassRequest.getRunner(ClassRequest.java:33) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:362) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:379) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:340) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:413) Caused by: java.util.concurrent.ExecutionException: java.io.IOException: Could not bind to localhost and 45940 - perhaps something else is bound to that address. at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1928) at org.apache.tinkerpop.gremlin.driver.remote.AbstractRemoteGraphProvider.startServer(AbstractRemoteGraphProvider.java:331) at org.apache.tinkerpop.gremlin.driver.remote.AbstractRemoteGraphProvider.<init>(AbstractRemoteGraphProvider.java:231) ... 27 more Caused by: java.io.IOException: Could not bind to localhost and 45940 - perhaps something else is bound to that address. at org.apache.tinkerpop.gremlin.server.GremlinServer$1.operationComplete(GremlinServer.java:186) at org.apache.tinkerpop.gremlin.server.GremlinServer$1.operationComplete(GremlinServer.java:173) at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:577) at io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:551) at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:490) at io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:615) at io.netty.util.concurrent.DefaultPromise.setFailure0(DefaultPromise.java:608) at io.netty.util.concurrent.DefaultPromise.tryFailure(DefaultPromise.java:117) at io.netty.channel.AbstractChannel$AbstractUnsafe.safeSetFailure(AbstractChannel.java:998) at io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:552) at io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1334) at io.netty.channel.AbstractChannelHandlerContext.invokeBind(AbstractChannelHandlerContext.java:506) at io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:491) at io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:973) at io.netty.channel.AbstractChannel.bind(AbstractChannel.java:248) at io.netty.bootstrap.AbstractBootstrap$2.run(AbstractBootstrap.java:356) at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164) at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at java.lang.Thread.run(Thread.java:748) ``` I've tested to check with `lsof -i :45940` to see if anything else was holding that port and i don't find anything. It makes me think that somehow the changes have stopped Gremlin Server from shutting down cleanly in integration tests?? I don't see any indication of that in the code but perhaps that is what is happening. I don't get these issue on `3.4-dev` which indicates that the problem is on this branch. I think that the reason you don't see error is because you `-DskipTests` in both commands which ignores unit tests which is precisely where the build is failing. Please try to build with `mvn clean install` and see if you hit the same problem as I have. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The gremlin server starts even if all graphs instantiation has failed > --------------------------------------------------------------------- > > Key: TINKERPOP-2436 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2436 > Project: TinkerPop > Issue Type: Bug > Components: server > Affects Versions: 3.4.8 > Reporter: Nicolas Trangosi > Priority: Major > > Sometimes the gremlin server fails to open the graph due to backend failure. > In this case, gremlin server starts even if could not serve any request as > gremlin-groovy GremlinScriptEngine is not initialized. I think that in this > case, gremlin server should stop (and be restarted in a kubernates cluster) > {{8 Oct 2020 12:35:51,923 8660 [gremlin-server-exec-1] ERROR > org.apache.tinkerpop.gremlin.jsr223.DefaultGremlinScriptEngineManager - > Could not create GremlinScriptEngine for gremlin-groovy}} > {{ java.lang.IllegalStateException: javax.script.ScriptException: > javax.script.ScriptException: groovy.lang.MissingPropertyException: No such > property: graph for class: Script1 }} > {noformat} > 08 Oct 2020 12:35:45,228 1965 [main] WARN > org.apache.tinkerpop.gremlin.server.GremlinServer - Graph [graph] configured > at [/etc/opt/janusgraph/janusgraph.properties] could not be instantiated and > will not be available in Gremlin Server. GraphFactory message: GraphFactory > could not instantiate this Graph implementation [class > org.janusgraph.core.JanusGraphFactory] > 08 Oct 2020 12:35:45,228 1965 [main] WARN > org.apache.tinkerpop.gremlin.server.GremlinServer - Graph [graph] configured > at [/etc/opt/janusgraph/janusgraph.properties] could not be instantiated and > will not be available in Gremlin Server. GraphFactory message: GraphFactory > could not instantiate this Graph implementation [class > org.janusgraph.core.JanusGraphFactory] > java.lang.RuntimeException: GraphFactory could not instantiate this Graph > implementation [class org.janusgraph.core.JanusGraphFactory] > at > org.apache.tinkerpop.gremlin.structure.util.GraphFactory.open(GraphFactory.java:81) > at > org.apache.tinkerpop.gremlin.structure.util.GraphFactory.open(GraphFactory.java:69) > at ... > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)