[
https://issues.apache.org/jira/browse/TINKERPOP-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485741#comment-17485741
]
ASF GitHub Bot commented on TINKERPOP-2681:
-------------------------------------------
spmallette commented on a change in pull request #1555:
URL: https://github.com/apache/tinkerpop/pull/1555#discussion_r797542035
##########
File path:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/reference/ReferenceVertex.java
##########
@@ -38,6 +38,10 @@ private ReferenceVertex() {
}
+ public ReferenceVertex(final Object id) {
Review comment:
good point. a "reference" really just needs to have enough information
to identify it so that it is attachable back to the graph. the label has never
been required to do that and ends up being a bit superfluous for the case where
the user wants to construct a reference independently of the graph as in the
case:
```java
g.V(1).addE('knows').to(new ReferenceVertex(2))
```
which I believe is allowed in different language variants currently.
Historically speaking, `ReferenceVertex` grew out of a need in OLAP (where the
label has more relevance) and then later became the currency of Gremlin Server
network serialization. Not sure if this constructor is dangerous for its
convenience. I'd be inclined to leave it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create merge() step to codify best practice for upsert pattern
> --------------------------------------------------------------
>
> Key: TINKERPOP-2681
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2681
> Project: TinkerPop
> Issue Type: Improvement
> Components: language, process
> Affects Versions: 3.5.1
> Reporter: Dave Bechberger
> Assignee: Stephen Mallette
> Priority: Major
>
> Create a step that codifies the best practice for the upsert functionality
> into a single step to make it easier to use, more discoverable, and easier
> for implementers to optimize.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
