[
https://issues.apache.org/jira/browse/TINKERPOP-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485751#comment-17485751
]
ASF GitHub Bot commented on TINKERPOP-2681:
-------------------------------------------
spmallette commented on a change in pull request #1555:
URL: https://github.com/apache/tinkerpop/pull/1555#discussion_r797546454
##########
File path:
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/WsGremlinBinaryRequestDecoder.java
##########
@@ -76,6 +76,7 @@ protected void decode(final ChannelHandlerContext
channelHandlerContext, final B
try {
objects.add(serializer.deserializeRequest(messageBytes.discardReadBytes()));
} catch (SerializationException se) {
+ logger.warn(se.getMessage());
Review comment:
i went in a two day hole of debugging because I couldn't figure out
where that a serialization problem from here was causing trouble. just wanted
some additional information in the logs here to help for that sort of problem
in the future. i will change the log messages to a general message and
stacktrace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create merge() step to codify best practice for upsert pattern
> --------------------------------------------------------------
>
> Key: TINKERPOP-2681
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2681
> Project: TinkerPop
> Issue Type: Improvement
> Components: language, process
> Affects Versions: 3.5.1
> Reporter: Dave Bechberger
> Assignee: Stephen Mallette
> Priority: Major
>
> Create a step that codifies the best practice for the upsert functionality
> into a single step to make it easier to use, more discoverable, and easier
> for implementers to optimize.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
