[
https://issues.apache.org/jira/browse/TINKERPOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948300#comment-17948300
] ASF GitHub Bot commented on TINKERPOP-3023: ------------------------------------------- codecov-commenter commented on PR #3104: URL: https://github.com/apache/tinkerpop/pull/3104#issuecomment-2840387628 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3104?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `45.45455%` with `6 lines` in your changes missing coverage. Please review. > Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`3.8-dev@866613a`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report. | [Files with missing lines](https://app.codecov.io/gh/apache/tinkerpop/pull/3104?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...in/language/grammar/DefaultGremlinBaseVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/3104?src=pr&el=tree&filepath=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FDefaultGremlinBaseVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL0RlZmF1bHRHcmVtbGluQmFzZVZpc2l0b3IuamF2YQ==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...remlin/language/grammar/GenericLiteralVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/3104?src=pr&el=tree&filepath=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FGenericLiteralVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL0dlbmVyaWNMaXRlcmFsVmlzaXRvci5qYXZh) | 25.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## 3.8-dev #3104 +/- ## ========================================== Coverage ? 76.59% Complexity ? 13786 ========================================== Files ? 1080 Lines ? 63444 Branches ? 7536 ========================================== Hits ? 48597 Misses ? 12292 Partials ? 2555 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/3104?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Expand type syntax in grammar in 3.8 > ------------------------------------ > > Key: TINKERPOP-3023 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3023 > Project: TinkerPop > Issue Type: Improvement > Components: language > Affects Versions: 3.8.0 > Reporter: Stephen Mallette > Priority: Major > > There are certain types commonly used in Gremlin that should have some native > support in the grammar: > * UUID > ** {{UUID()}} - random > ** {{UUID('1e077e63-e45a-4f8e-aa00-9b6ffd91f20e')}} > * Edge > ** {{Edge(11)}} - different than current syntax for Vertex, adjust Vertex to > match - drop grammar support for {{{}ReferenceVertex{}}}. > * Binary (ByteBuffer) > ** {{Binary( '/9j/4AAQSkZJRgABAQEAAAAAAAD/==')}} -- This message was sent by Atlassian Jira (v8.20.10#820010)
