[ 
https://issues.apache.org/jira/browse/TINKERPOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948798#comment-17948798
 ] 

ASF GitHub Bot commented on TINKERPOP-3023:
-------------------------------------------

xiazcy commented on code in PR #3104:
URL: https://github.com/apache/tinkerpop/pull/3104#discussion_r2071054187


##########
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/sideEffect/Uuid.feature:
##########
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+@StepClassSideEffect @StepUuid
+Feature: Step - uuid()

Review Comment:
   Given uuid() isn't an actual step, please add this test into the 
`Inject.feature` file instead of creating this separate one that doesn't make 
sense. 





> Expand type syntax in grammar in 3.8
> ------------------------------------
>
>                 Key: TINKERPOP-3023
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3023
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language
>    Affects Versions: 3.8.0
>            Reporter: Stephen Mallette
>            Priority: Major
>
> There are certain types commonly used in Gremlin that should have some native 
> support in the grammar:
>  * UUID
>  ** {{UUID()}} - random
>  ** {{UUID('1e077e63-e45a-4f8e-aa00-9b6ffd91f20e')}}
>  * Edge
>  ** {{Edge(11)}} - different than current syntax for Vertex, adjust Vertex to 
> match - drop grammar support for {{{}ReferenceVertex{}}}.
>  * Binary (ByteBuffer)
>  ** {{Binary( '/9j/4AAQSkZJRgABAQEAAAAAAAD/==')}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to