[ 
https://issues.apache.org/jira/browse/TINKERPOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949099#comment-17949099
 ] 

ASF GitHub Bot commented on TINKERPOP-3023:
-------------------------------------------

Cole-Greer commented on code in PR #3112:
URL: https://github.com/apache/tinkerpop/pull/3112#discussion_r2072230733


##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/gremlin.js:
##########
@@ -1683,6 +1683,7 @@ const gremlins = {
     g_VX1X_out_out_out_tree: [function({g}) { return 
g.V().out().out().out().tree() }], 
     g_VX1X_outE_inV_bothE_otherV_tree: [function({g, vid1}) { return 
g.V(vid1).outE().inV().bothE().otherV().tree() }], 
     g_VX1X_outE_inV_bothE_otherV_tree_byXnameX_byXlabelX: [function({g, vid1}) 
{ return g.V(vid1).outE().inV().bothE().otherV().tree().by("name").by(T.label) 
}], 
+    g_injectXUUIDX: [function({g}) { return 
g.inject("f47af10b-58cc-4372-a567-0f02b2f3d479") }], 

Review Comment:
   I don't think this is the right translation for JS. It should be injecting a 
UUID type not simply a String.





> Expand type syntax in grammar in 3.8
> ------------------------------------
>
>                 Key: TINKERPOP-3023
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3023
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language
>    Affects Versions: 3.8.0
>            Reporter: Stephen Mallette
>            Priority: Major
>
> There are certain types commonly used in Gremlin that should have some native 
> support in the grammar:
>  * UUID
>  ** {{UUID()}} - random
>  ** {{UUID('1e077e63-e45a-4f8e-aa00-9b6ffd91f20e')}}
>  * Edge
>  ** {{Edge(11)}} - different than current syntax for Vertex, adjust Vertex to 
> match - drop grammar support for {{{}ReferenceVertex{}}}.
>  * Binary (ByteBuffer)
>  ** {{Binary( '/9j/4AAQSkZJRgABAQEAAAAAAAD/==')}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to