[
https://issues.apache.org/jira/browse/TINKERPOP-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18022741#comment-18022741
]
ASF GitHub Bot commented on TINKERPOP-2234:
-------------------------------------------
spmallette commented on code in PR #3211:
URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2378815254
##########
docs/src/reference/the-traversal.asciidoc:
##########
@@ -5480,7 +5480,7 @@ the release of TinkerPop 3.4.0, Gremlin also supports
simple text predicates, wh
text predicates extend the `P` predicates, but are specialized in that they
are of the form `Function<String,Boolean>`.
The provided predicates are outlined in the table below and are used in
various steps such as <<has-step,`has()`>>-step,
<<where-step,`where()`>>-step, <<is-step,`is()`>>-step, etc. Two new
additional `TextP` predicate members were added in the
-TinkerPop 3.6.0 release that allow working with regular expressions. These are
`TextP.regex` and `TextP.notRegex`
+TinkerPop 3.6.0 release that allow working with regular expressions. These are
`TextP.regex` and `TextP.notRegex`. Starting with TinkerPop 3.8.0, a new type
predicate `P.typeOf` is added to support filtering traversers based on types.
Review Comment:
Could you please take this moment to clean up this Note on Predicates
section? I don't think there's any value to speaking about 3.4.0 and other
versions. Have this section just talk about predicates.
##########
docs/src/reference/the-traversal.asciidoc:
##########
@@ -5480,7 +5480,7 @@ the release of TinkerPop 3.4.0, Gremlin also supports
simple text predicates, wh
text predicates extend the `P` predicates, but are specialized in that they
are of the form `Function<String,Boolean>`.
The provided predicates are outlined in the table below and are used in
various steps such as <<has-step,`has()`>>-step,
<<where-step,`where()`>>-step, <<is-step,`is()`>>-step, etc. Two new
additional `TextP` predicate members were added in the
-TinkerPop 3.6.0 release that allow working with regular expressions. These are
`TextP.regex` and `TextP.notRegex`
+TinkerPop 3.6.0 release that allow working with regular expressions. These are
`TextP.regex` and `TextP.notRegex`. Starting with TinkerPop 3.8.0, a new type
predicate `P.typeOf` is added to support filtering traversers based on types.
Review Comment:
Could you please take this moment to clean up this Note on Predicates
section? I don't think there's any value to speaking about 3.4.0 and other
versions. Have this section just talk about predicates and what they are.
> Introduce Type Predicate
> ------------------------
>
> Key: TINKERPOP-2234
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2234
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.4.2
> Reporter: Stephen Mallette
> Priority: Major
>
> Provide for a {{typeOf()}} predicate that allows for testing the type of an
> object which would enable neat things like:
> {code}
> g.V().outE().has('weight',gt(0.1)).inV().path().unfold().is(typeOf(VERTEX))
> {code}
> See the linked DISCUSS thread for more information.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
