[ https://issues.apache.org/jira/browse/TINKERPOP-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18022770#comment-18022770 ]
ASF GitHub Bot commented on TINKERPOP-2234: ------------------------------------------- spmallette commented on code in PR #3211: URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2378936577 ########## gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AsNumberStepTest.java: ########## @@ -18,7 +18,7 @@ */ package org.apache.tinkerpop.gremlin.process.traversal.step.map; -import org.apache.tinkerpop.gremlin.process.traversal.N; +import org.apache.tinkerpop.gremlin.process.traversal.GType; Review Comment: maybe i'm missing it, but where are the tests for cases where you supply a non-numeric `GType` to `asNumber` like `asNumber(GType.Vertex)`? > Introduce Type Predicate > ------------------------ > > Key: TINKERPOP-2234 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2234 > Project: TinkerPop > Issue Type: Improvement > Components: process > Affects Versions: 3.4.2 > Reporter: Stephen Mallette > Priority: Major > > Provide for a {{typeOf()}} predicate that allows for testing the type of an > object which would enable neat things like: > {code} > g.V().outE().has('weight',gt(0.1)).inV().path().unfold().is(typeOf(VERTEX)) > {code} > See the linked DISCUSS thread for more information. -- This message was sent by Atlassian Jira (v8.20.10#820010)