[
https://issues.apache.org/jira/browse/TINKERPOP-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18022840#comment-18022840
]
ASF GitHub Bot commented on TINKERPOP-2234:
-------------------------------------------
xiazcy commented on code in PR #3211:
URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2379693175
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/CompareType.java:
##########
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.process.traversal;
+
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * {@code CompareType} is a {@code BiPredicate} that determines whether the
first argument is a type of the second argument.
+ *
+ */
+public enum CompareType implements PBiPredicate<Object, Class<?>> {
+
+ /**
+ * Evaluates if the first object is an instance of the second class.
+ *
+ * @since 3.8.0
+ */
+ typeOf {
+ @Override
+ public boolean test(final Object first, final Class<?> second) {
+ if (first == null) {
+ return second == null;
+ }
+ return second != null && second.isAssignableFrom(first.getClass());
Review Comment:
Yes, I had a thought on it as well. I leaned towards inheritance but the
idea of having `typeEquals` (or `tyepEq`?) for exact class match might not be a
bad idea for later.
> Introduce Type Predicate
> ------------------------
>
> Key: TINKERPOP-2234
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2234
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.4.2
> Reporter: Stephen Mallette
> Priority: Major
>
> Provide for a {{typeOf()}} predicate that allows for testing the type of an
> object which would enable neat things like:
> {code}
> g.V().outE().has('weight',gt(0.1)).inV().path().unfold().is(typeOf(VERTEX))
> {code}
> See the linked DISCUSS thread for more information.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
