Hello, I would prefer to keep internal StarGraph methods private. Can the code simply not use addEdge() which is public?
Marko. On Jun 22, 2015, at 9:01 AM, spmallette <[email protected]> wrote: > Github user spmallette commented on the pull request: > > > https://github.com/apache/incubator-tinkerpop/pull/85#issuecomment-114141984 > > Thanks for attempting to expand this capability. > > You added `GraphSONLegacyReader` which basically reads TP2 GraphSON in the > titan adjacency list style. Is that the primary difference between it and > the original `LegacyGraphSONReader`? If so, i wonder if they couldn't be > combined in some way such that you just could configure in the `Builder` > whether to use adjacency list or edge list style...wdyt? > > I see you had to make these `public` on `StarGraph`: > > > https://github.com/apache/incubator-tinkerpop/pull/85/files#diff-60db5b3a8acf1e835406ee1f75f02903R289 > > https://github.com/apache/incubator-tinkerpop/pull/85/files#diff-60db5b3a8acf1e835406ee1f75f02903R305 > > I've pulled back from doing that a few times now to try to reduce exposure > of too much of the internals of `StarGraph`. > > @okram do you have any thoughts on that? > > i gave the record reader/input format portion of this quick review, but > don't have anything specific to say on that just yet - @dkuppitz any thoughts > there? > > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > ---
