Github user edi-bice commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/85#issuecomment-114166588
  
    @spmallette yes that is the primary difference. I wasn't even aware of the 
two types of GraphSON until a couple of days ago. It's been a bit confusing 
dealing with GraphSON in its two flavors and then all the changes between TP2 
and TP3. If you think it makes more sense to combine and use the Builder I can 
do that.
    
    Yes, I couldn't figure out how to add the StarGraph edges without making 
those methods public. Also extracted out LegacyGraphSONUtility hoping to use 
its vertex/edgeFromJson but then went with StarGraph. Will see what else of it 
I am still using and try to bring it back as inner class of the 
LegacyGraphSONReader I believe.
    
    I apologize for some of the mess. Just wanted to get your opinion and make 
sure I was going in the right direction. Thanks for the feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to