Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/85#issuecomment-114177314
> yes that is the primary difference...If you think it makes more sense to
combine and use the Builder I can do that.
I guess a design might be to have one `LegacyGraphSONReader` but then have
two separate "internal" implementations of it (i.e. one for adjacency list and
one for edge list). Based on the `Builder` options you just choose the right
internal class to use in the `LegacyGraphSONReader`. That way things stay
separate but all notion of "legacy" to end-users is hidden behind a single
`LegacyGraphSONReader` class.
> Just wanted to get your opinion and make sure I was going in the right
direction.
I think it's good that you're taking an iterative approach to this and
requesting feedback early. We'll keep an eye out for your next revision of
this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
