On 20/09/18 12:19, Mark Thomas wrote: > On 20/09/18 11:27, Rainer Jung wrote: >> Partial results (IMHO no show-stoppers so far): >> >> - the following zip files previously contained LICENSE, NOTICE > > That is a show-stopper. But at least I can rebuild the binaries with > those files. No need to re-tag. I wonder what went wrong. I don't think > I did anything different.
Figured it out. I built the binaries from the source distribution rather than from an svn checkout / export. The native/LICENSE and native/NOTICE files aren't in the source distribution. >> and do no >> longer contain them. The symbol files in addition miss the previously >> contained README file: > > Less of an issue but I'll fix that too. Looks to be the same cause. I'll look at the source packaging for the next release as well. Mark > >> - >> binaries/windows/symbols/tomcat-connectors-1.2.45-windows-i386-symbols.zip >> - >> binaries/windows/symbols/tomcat-connectors-1.2.45-windows-x86_64-symbols.zip >> >> - binaries/windows/tomcat-connectors-1.2.45-windows-i386-iis.zip >> - binaries/windows/tomcat-connectors-1.2.45-windows-x86_64-iis.zip >> >> You might want to add the files to these artefacts? > > Will do. > >> - The file native/iis/pcre/testdata/grepbinary got currupted by >> lineends.pl in the source zip. I added a feature to lineends.pl and used >> it in jk-release.sh to prevent this from happening in the future. > > Thanks. > >> - the file .gitignore is missing in the top-level directory of the >> source distribution. Added to jk-release.sh now for the future. > > And thanks again. > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
