On Tue, Nov 19, 2019 at 5:58 PM Mark Thomas <ma...@apache.org> wrote:
> On 19/11/2019 00:44, Konstantin Kolinko wrote: > > вт, 19 нояб. 2019 г. в 01:42, Mark Thomas <ma...@apache.org>: > >> > >> On 18/11/2019 22:01, Rémy Maucherat wrote: > >>> On Mon, Nov 18, 2019 at 10:22 PM Mark Thomas <ma...@apache.org > >>> <mailto:ma...@apache.org>> wrote: > >> > >>> Is porting the multipoller removal to 7.0 really doable ? > >> > >> I don't know. I haven't looked at the code yet. I do have an alternative > >> fix I tested that should work if back-porting proves tricky. > >> > >>> It could be running on older Windows platforms maybe. > >> > >> That would only be an issue of the versions of Windows were so old they > >> were no longer supported by Microsoft. Users in those circumstances are > >> unlikely to be updating to the latest 7.0.x release anyway. Therefore > >> that isn't something I'm particularly worrying about. (But I am happy to > >> be over-ruled if the consensus is not to back-port to 7.0.x.) > > > > Searching my mailbox and archives at https://tomcat.markmail.org/, > > > > a) Tomcat 7.0.96 running on Windows XP was mentioned recently (August > 2019) > > https://bz.apache.org/bugzilla/show_bug.cgi?id=63625#c16 > > > > b) Tomcat 8.5 was never mentioned running on Windows XP or on Windows > 2003. > > There was one thread about Tomcat 8.5.3 when a client was using > > Windows XP, but Tomcat was running on Ubuntu. > > There was one thread in year 2017 about posting an application from an > > old server running Windows 2003 and Tomcat 5 to Tomcat 8.5. > > https://markmail.org/thread/qvmzmmjz2dqohbk5 > > > > I think the single pollset change should not be backported to Tomcat 7. > > I am OK with it being backported to Tomcat 8.5. > > In favour of back-porting: > - It keeps the code (more) aligned so future maintenance is easier > - It is more obvious where previous APR fixes have not been back-ported > (as well as being easier to back-port them). I can see a handful of > fixes it would be worth back-porting > - Windows XP / Server 2003 are out of support. I think it would be > unusual for a user to be keeping Tomcat up to date but not the OS. > - sendfile is already using a larger pollset size and we have had no > complaints (that I recall) > > I've just finished back-porting the single pollset change. I want to > backport the additional fixes I can now see and then run the unit tests. > > I'd like to then commit these changes but I can do it via a PR if folks > want a chance to review them first. > +1 for attempting it, if you're comfortable about it it should be fine. Rémy
