On 20/11/2019 14:03, Konstantin Kolinko wrote: > вт, 19 нояб. 2019 г. в 19:58, Mark Thomas <ma...@apache.org>: >> >> On 19/11/2019 00:44, Konstantin Kolinko wrote: >>> вт, 19 нояб. 2019 г. в 01:42, Mark Thomas <ma...@apache.org>: >>> >>> I think the single pollset change should not be backported to Tomcat 7. >>> I am OK with it being backported to Tomcat 8.5. >> >> In favour of back-porting: >> [...] >> - Windows XP / Server 2003 are out of support. I think it would be >> unusual for a user to be keeping Tomcat up to date but not the OS. >> - sendfile is already using a larger pollset size and we have had no >> complaints (that I recall) > > Updating an OS costs money (if it is Windows) and may be not possible > due to hardware limitations. > > That said, reviewing the changes and comments once again, > I see that this is not a showstopper for Windows XP users, if there are any. > > The comments say about reduced performance, not an inability to run Tomcat. > The pollset size can be adjusted by configuring maxConnections="1024" > or less. I think that is a reasonable value for some legacy server. > > Thus OK to backport to Tomcat 7. > > Looking into documentation, > http://tomcat.apache.org/tomcat-7.0-doc/config/http.html > Regarding maxConnections it says > "Note that for APR/native on Windows, the configured value will be > reduced to the highest multiple of 1024 that is less than or equal to > maxConnections." > > I think that is no longer true.
Good catch. I'll check the default as well. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
