On 19/11/2019 19:29, Rémy Maucherat wrote: > On Tue, Nov 19, 2019 at 5:58 PM Mark Thomas <ma...@apache.org > <mailto:ma...@apache.org>> wrote: > > On 19/11/2019 00:44, Konstantin Kolinko wrote:
<snip/> > > I think the single pollset change should not be backported to > Tomcat 7. > > I am OK with it being backported to Tomcat 8.5. > > In favour of back-porting: > - It keeps the code (more) aligned so future maintenance is easier > - It is more obvious where previous APR fixes have not been back-ported > (as well as being easier to back-port them). I can see a handful of > fixes it would be worth back-porting > - Windows XP / Server 2003 are out of support. I think it would be > unusual for a user to be keeping Tomcat up to date but not the OS. > - sendfile is already using a larger pollset size and we have had no > complaints (that I recall) > > I've just finished back-porting the single pollset change. I want to > backport the additional fixes I can now see and then run the unit tests. > > I'd like to then commit these changes but I can do it via a PR if folks > want a chance to review them first. > > > +1 for attempting it, if you're comfortable about it it should be fine. FYI, the single pollset changes back-ported easily along with one other fix. The other fixes were not as clean so I decided to leave them for now. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
