On 07/04/2020 19:03, Filip Hanik wrote: > > > On Tue, Apr 7, 2020 at 9:35 AM Rémy Maucherat <r...@apache.org > <mailto:r...@apache.org>> wrote: > > > Does the connector need to know about the actual implementations? > > > Ideally no, but it removes the reflection you say is bad for Graal. > > > Correct. Turns out that the connectors use setProperty/getProperty via > reflection (IntrospectionUtils.setProperty/getProperty), so changing > only this constructor would achieve a mini step. > Before we commit any changes, I'd like to evaluate the scope of > reflection we're dealing with. > > Then I can come back. I'll close the PR for now, as it only touches the > surface. > > sound fair?
Sounds reasonable. I'm happy for any obvious clean-up to stay though. On a similar note, the ProtocolHandler calls setProperty() on the Endpoint which then also uses reflection. I think I have a way around this but it is not great for maintenance. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
