On 21/07/2020 12:43, Coty Sutherland wrote: > Hi Mark, > > On Tue, Jul 21, 2020 at 4:48 AM Mark Thomas <ma...@apache.org > <mailto:ma...@apache.org>> wrote: > > On 20/07/2020 18:20, Coty Sutherland wrote: > > This commit is problematic :( It's broken some projects that depend on > > Tomcat because now the tomcat-coyote.jar doesn't contain the > > org.apache.tomcat.util.net <http://org.apache.tomcat.util.net>.jsse or > > org.apache.tomcat.util.modeler.modules packages which results in > > ClassNotFoundExceptions. I haven't seen any issues with other jars > yet. > > The removal of those packages from the jar looks intentional, but we > > aren't providing the classes anywhere else for users to use which is > > causing problems. Thoughts? > > Those packages are still present. > > > It seems that removing the packages from the exported packages list > actually removed them completely from the tomcat-coyote.jar (I > decompiled it to look and they were not present, nor were they included > in any other jars).
I've just checked the 9.0.37 binaries and those packages (and the classes they contain) are present in tomcat-coyote.jar. I saw the same when I built 10.0.x locally (before my fix). >From where did you obtain a JAR where those classes were missing? > Thanks for looking into it, the fix you did was the same patch that I > added yesterday > (https://src.fedoraproject.org/rpms/tomcat/c/a8c5ea85614dca66b492fe030a7e7cfc10cd52de?branch=master) > :) I wish I'd proposed it upstream now, I just wasn't sure what the > criteria was for not exporting the packages. > > The packages that were pointed out to me as broken are FreeIPA server > (https://bugzilla.redhat.com/show_bug.cgi?id=1857043) and Debian's > libtomcat9-java package > (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964433), both with > different CNFEs. Tx. I'm curious as whether the root cause was missing classes or missing exports - but that depends on figuring out why the classes were missing first. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
