Just FYI, I found that if I build when the aqute-bnd and aqute-bndlib packages are installed from Fedora (version 3.5) then the classes are *not* included in the jar, but if I remove them and use the aqute-bnd version that tomcat requires (version 5.1) then they are present.
On Tue, Jul 21, 2020 at 10:26 AM Raymond Auge <raymond.a...@liferay.com.invalid> wrote: > Hey all, > > Thanks for looking into this. I made sure using a binary comparison tool > that the jars did in fact contained the correct bits before and after all > my changes. > > But Mark is correct that some of the previously private packages are > actually used externally and I had some changes coming to deal with those > (but presently I'm on vacation so thanks for handling some of those those > Mark.) > > Sincerely, > - Ray > > On Tue, Jul 21, 2020 at 9:51 AM Coty Sutherland <csuth...@apache.org> > wrote: > >> <snip> >> >> That looks like an issue that will need fixing in Fedora's build system. >>> Annotation scanning and the multipart upload API will be broken if those >>> packages are missing. >>> >> >> Hm, OK. I'll look into that and I guess other changes to ensure the >> Fedora build isn't breaking stuff. I need to figure out why the step is >> removing the classes and fix that issue since it doesn't seem to affect our >> binary distro :( >> >> Going back to the fix I applied. The JSSE package was being used >>> externally so that change looks to be OK. The modeler.modules package >>> was not so I'm currently leaning towards reverting that part of the >>> change. >>> >>> Overall, I don't mind exposing these packages externally if necessary >>> but I'd prefer not to expose them if we don't have to. >>> >> >> I agree and I'm fine with reverting your fix (I think) and continuing >> with the patch I've applied in Fedora to keep that working. It's noteworthy >> to mention again though that Debian had the same issue too, so whatever the >> issue is that's causing the classes to be removed isn't just a Fedora >> problem. >> > > > -- > *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile> > (@rotty3000) > Senior Software Architect *Liferay, Inc.* <http://www.liferay.com> > (@Liferay) >
