Tweaked it slightly. Moved the shading outside the main build as plugins like maven-assembly-plugin can't handle the shading, it puts both in the resulting zip. Had to deal with that for OpenJPA as well for the 1.6.0 release -- our zip size went up 5mb when I put it in the build.
Also switched the version to 2.2.0-SNAPSHOT so the tomee-trunk-deploy builder will (hopefully) work. -David On Dec 5, 2013, at 1:58 AM, Romain Manni-Bucau <[email protected]> wrote: > hopefully it should work now. I didnt check tomee only provides quartz > shade but our quartz ra tests are passing (if any volonteer...) > > Note: I kept org.quartz config in EjbTimerServiceImpl but we should > replace it by org.apache.openejb.quartz.* (here again if any volonteer > ;). > Romain Manni-Bucau > Twitter: @rmannibucau > Blog: http://rmannibucau.wordpress.com/ > LinkedIn: http://fr.linkedin.com/in/rmannibucau > Github: https://github.com/rmannibucau > > > > 2013/12/5 Mark Struberg <[email protected]>: >> >> >> +1 for shading. Always good to prevent classpath clashes without having to >> provide expensive ClassLoader tricks. >> >> The only obstacle is if there is some configuration which needs to be read >> from a file with a fixed name. >> >> LieGrue, >> strub >> >> >> >> >> >>> ________________________________ >>> From: David Blevins <[email protected]> >>> To: [email protected] >>> Sent: Thursday, 5 December 2013, 2:38 >>> Subject: Re: Quartz, next >>> >>> >>> Trying the shaded approach would certainly be interesting. >>> >>> There's a lot of merit to it if we can work through the obvious issues and >>> test the heck out of it. >>> >>> >>> -David >>> >>> >>> On Dec 3, 2013, at 12:57 AM, Romain Manni-Bucau <[email protected]> >>> wrote: >>> >>>> Ps: forgot another solutuon: shade quartz in org.apache.openejb.quartz >>>> Le 2 déc. 2013 22:23, "Romain Manni-Bucau" <[email protected]> a écrit >>>> : >>>> >>>>> Hi >>>>> >>>>> How do we handle quartz for next releases? It is very often a pain >>>>> >>>>> I propose: >>>>> 1) if in openejb loader use this one >>>>> 2) if not look for it in tomee/quartz/*.jar and create a loader with it >>>>> >>>>> Tomee would use 2 by default >>>>> >>>>> Wdyt? >>>>> >>> >>> >>>
